openerp-dev-web team mailing list archive

Thread
Date

Re: [Merge] lp:~openerp-dev/openobject-server/trunk-bug-740799-nch into lp:openobject-server

To: "Naresh\(OpenERP\)" <nch@xxxxxxxxxxx>
From: "Vo Minh Thu \(OpenERP\)" <vmt@xxxxxxxxxxx>
Date: Mon, 23 May 2011 09:21:27 -0000
In-reply-to: <20110518124452.12385.6880.launchpad@loganberry.canonical.com>
Reply-to: mp+61392@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
- Notice how, in the many2one case, there are three cases: string, id, ids. Please correct your code to allow the same things,
- Same for the one2many case.
- Please add tests to openerp/addons/base/test/test_osv_expression.yml
(You can use the Customer/Segmentation/{Bad,Important} categories).

If you notice any duplication of code, please refactor it as a function/method.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-740799-nch/+merge/61392
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bug-740799-nch.

References

[Merge] lp:~openerp-dev/openobject-server/trunk-bug-740799-nch into lp:openobject-server
From: Naresh(OpenERP), 2011-05-18