openerp-dev-web team mailing list archive

Thread
Date

Re: lp:~openerp-dev/openobject-addons/trunk-usability-Be_able_to_cancel_some_documents-han into lp:~openerp-dev/openobject-addons/trunk-usability

To: mp+61920@xxxxxxxxxxxxxxxxxx
From: "Raphael Collet \(OpenERP\)" <rco@xxxxxxxxxxx>
Date: Tue, 24 May 2011 09:42:31 -0000
In-reply-to: <20110523065927.17316.38924.launchpad@loganberry.canonical.com>
Reply-to: mp+61920@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
The changes in sale/sale.py and sale/sale_view.xml are fine.

But the other changes are incorrect: you changed the workflow!
You simply cannot cancel a sale order with state 'done'.
Please undo the changes you have made in module stock.

The missing bit is: in the sales order form view (sale/sale_view.xml), under the field picking_ids, add a button to cancel those pickings (you can label it "Cancel all Pickings").  See how pickings are cancelled, and reuse that for the action of your button.

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-usability-Be_able_to_cancel_some_documents-han/+merge/61920
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-usability.

References

lp:~openerp-dev/openobject-addons/trunk-usability-Be_able_to_cancel_some_documents-han into lp:~openerp-dev/openobject-addons/trunk-usability
From: Hardik Ansodariya (OpenERP), 2011-05-23