Thread Previous • Date Previous • Date Next • Thread Next |
Hi Raphael,glad you noticed this wrong commit on time. At least it is directly reverted.
Still the question remains how we (OpenERP SA and community) can prevent such functional change commits that can/will brake functionality.
The commit was marked as an improvement but it was the opposite. @odonyPlease let make some procedures how we should report bugs, fix bugs, test made solutions and make those solutions public. The software is getting that big that there should be domain owners that will check every single solution provided by a developer before it is committed. Where people are working, mistakes will happen, but we should make that happen less. After a IRC meeting 1,5 year ago, where this issue is discussed also, I have send on request of Fabien on 10 March 2009 a email to Fabien and Christophe S. with a detailed proposal that could be the base for making such procedures. But till now I guess nothing has happened. At least we didn't see anything. I hope the 2 given examples by Raphael and Kaspers (and there are more to find) justify the need of this.
I have sent a proposal to the openerp-expert-community list which is the right place to discus this.
https://lists.launchpad.net/openerp-community-leaders/msg00117.html ------------------------------------------------------------------------ Met vriendelijke groet, *Veritos - Open Source Business Solutions Jan Verlaan CPIM* Op 04-08-10 21:53, Raphaël Valyi schreef:
I had to make a ton of noise, but fortunately OpenERP S.A. reverted it in commit odo@xxxxxxxxxxx-20100804185919-imyt8sm0bzzsbmf6 Hopefully one day they start sorting out their internal code review process/hiring process and stop picturing themselves as the ultimate "quality authority" everybody should pay for. It's a bit tiring to see how much effort is required to get sanity refactoring get merged in the trunk versus how they can easily commit nonsense code internally, a bit far from how open source leads to quality... Regards, Raphaël Valyi Founder and ERP Consultant +55 21 3010 9965 http://www.akretion.com <http://www.akretion.com.br/> 2010/8/4 Raphaël Valyi<rvalyi@xxxxxxxxx>Hello folks, I think I explained it pretty much there: http://www.openobject.com/forum/post59620.html#59620 Thoughts? Raphaël Valyi Founder and ERP Consultant +55 21 3010 9965 http://www.akretion.com <http://www.akretion.com.br/>_______________________________________________ Mailing list: https://launchpad.net/~openerp-expert-accounting Post to : openerp-expert-accounting@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~openerp-expert-accounting More help : https://help.launchpad.net/ListHelp
Thread Previous • Date Previous • Date Next • Thread Next |