← Back to team overview

openerp-india team mailing list archive

[Bug 1002773] [NEW] reconcile opening balance entries

 

*** This bug is a security vulnerability ***

Public security bug reported:

In addition to the problem identified in  Addons  Bug #901166

We have encountered a problem with reconciling with entries from a
'posted' opening balance.

The error is:   "The account move (RAN/2012/0001) for centralisation has
been confirmed!"

it appears that there is an explicit check in centralised entries that it MUST be 'draft' and not 'posted'.
Actually, at least in France, as long as the journal isn't closed, entries can be reconciled/unreconciled but not otherwise modified.

To temporarily get over the problem, I set the state back to 'draft' and
reconcile works fine. But this leaves the RAN unprotected (not
'posted'), therefore quite dangerous.

I believe these should be addressed with priority.

from account_move_line.py
    def _check_moves(self, cr, uid, context=None):
        # use the first move ever created for this journal and period
        if context is None:
            context = {}
        cr.execute('SELECT id, state, name FROM account_move WHERE journal_id = %s AND period_id = %s ORDER BY id limit 1', (context['journal_id'],context['period_id']))
        res = cr.fetchone()
        if res:
            if res[1] != 'draft':
                raise osv.except_osv(_('UserError'),
                       _('The account move (%s) for centralisation ' \
                                'has been confirmed!') % res[2])
        return res


~/src/openerp/addons/6.1$ bzr version-info
revision-id: launchpad_translations_on_behalf_of_openerp-20120515052656-hjqg6rq32robbe9t
date: 2012-05-15 05:26:56 +0000
build-date: 2012-05-22 11:47:25 +0200
revno: 6798
branch-nick: 6.1

** Affects: openobject-addons
     Importance: Undecided
         Status: New


** Tags: opening-balance reconcile

** Visibility changed to: Public

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1002773

Title:
  reconcile opening balance entries

Status in OpenERP Addons (modules):
  New

Bug description:
  In addition to the problem identified in  Addons  Bug #901166

  We have encountered a problem with reconciling with entries from a
  'posted' opening balance.

  The error is:   "The account move (RAN/2012/0001) for centralisation
  has been confirmed!"

  it appears that there is an explicit check in centralised entries that it MUST be 'draft' and not 'posted'.
  Actually, at least in France, as long as the journal isn't closed, entries can be reconciled/unreconciled but not otherwise modified.

  To temporarily get over the problem, I set the state back to 'draft'
  and reconcile works fine. But this leaves the RAN unprotected (not
  'posted'), therefore quite dangerous.

  I believe these should be addressed with priority.

  from account_move_line.py
      def _check_moves(self, cr, uid, context=None):
          # use the first move ever created for this journal and period
          if context is None:
              context = {}
          cr.execute('SELECT id, state, name FROM account_move WHERE journal_id = %s AND period_id = %s ORDER BY id limit 1', (context['journal_id'],context['period_id']))
          res = cr.fetchone()
          if res:
              if res[1] != 'draft':
                  raise osv.except_osv(_('UserError'),
                         _('The account move (%s) for centralisation ' \
                                  'has been confirmed!') % res[2])
          return res

  
  ~/src/openerp/addons/6.1$ bzr version-info
  revision-id: launchpad_translations_on_behalf_of_openerp-20120515052656-hjqg6rq32robbe9t
  date: 2012-05-15 05:26:56 +0000
  build-date: 2012-05-22 11:47:25 +0200
  revno: 6798
  branch-nick: 6.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1002773/+subscriptions


Follow ups

References