← Back to team overview

openerp-india team mailing list archive

[Bug 966083] Re: Space as thousands separator does not show on reports

 

Hello,

I have fixed report issue in folowing branch, now reports will display space as thousand separator,
lp:~openerp-dev/openobject-server/6.1-opw-575181-rha
r4184  rid: rha@xxxxxxxxxxx-20120530070801-um47deb2v0wnv071

More over, GTK client too doesn't display space as thousand separator for float values, so I have
created another fix for GTK,
lp:~openerp-dev/openobject-client/6.1-opw-575181-rha
r2064 rha@xxxxxxxxxxx-20120530071029-n8qpov1po0n02lr4

Thanks for the bug report.
Regards,
Rifakat Haradwala

** Changed in: openobject-server
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/966083

Title:
  Space as thousands separator does not show on reports

Status in OpenERP Server:
  Fix Committed

Bug description:
  the current code deletes all spaces from floats in reports. This was
  reported ages ago in #615403 but never fixed. The fix is extremely
  simple there is no reason not too fix it.

  Here is a diff of the fix to the bug (we just need to remove the code that removes the white space)
  === modified file 'openerp/addons/base/res/res_lang.py'
  --- openerp/addons/base/res/res_lang.py	2012-01-24 13:17:05 +0000
  +++ openerp/addons/base/res/res_lang.py	2012-03-27 10:06:16 +0000
  @@ -214,11 +214,6 @@
                   parts[0], seps = intersperse(parts[0], eval_lang_grouping, thousands_sep)
   
               formatted = decimal_point.join(parts)
  -            while seps:
  -                sp = formatted.find(' ')
  -                if sp == -1: break
  -                formatted = formatted[:sp] + formatted[sp+1:]
  -                seps -= 1
           elif percent[-1] in 'diu':
               if grouping:
                   formatted = intersperse(formatted, eval_lang_grouping, thousands_sep)[0]

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/966083/+subscriptions


References