← Back to team overview

openerp-india team mailing list archive

[Bug 1038836] [NEW] point_of_sale module wrong inheritance

 

Public bug reported:


On point_of_sale/account_bank_statement.py line 46:


def _equal_balance(self, cr, uid, cash_id, context=None):
        statement = self.browse(cr, uid, cash_id, context=context)
        if not statement.journal_id.check_dtls:
            return True
        if statement.journal_id.check_dtls and (statement.balance_end != statement.balance_end_cash):
            return False
        else:
            return True

This is wrong. My suggest:

    def _equal_balance(self, cr, uid, cash_id, context=None):
        statement = self.browse(cr, uid, cash_id, context=context)
        if not statement.journal_id.check_dtls:
            return True
        return super(account_cash_statement, self)._equal_balance(cr, uid, cash_id, context=context)

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1038836

Title:
  point_of_sale module wrong inheritance

Status in OpenERP Addons (modules):
  New

Bug description:
  
  On point_of_sale/account_bank_statement.py line 46:

  
  def _equal_balance(self, cr, uid, cash_id, context=None):
          statement = self.browse(cr, uid, cash_id, context=context)
          if not statement.journal_id.check_dtls:
              return True
          if statement.journal_id.check_dtls and (statement.balance_end != statement.balance_end_cash):
              return False
          else:
              return True

  This is wrong. My suggest:

      def _equal_balance(self, cr, uid, cash_id, context=None):
          statement = self.browse(cr, uid, cash_id, context=context)
          if not statement.journal_id.check_dtls:
              return True
          return super(account_cash_statement, self)._equal_balance(cr, uid, cash_id, context=context)

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1038836/+subscriptions


Follow ups

References