openerp-india team mailing list archive

[Houssine <1047525@xxxxxxxxxxxxxxxxxx>]

Hi Luc,

Thanks for this contribution I'll look at the updated code.

Regards,
Houssine


2012/11/28 Luc De Meyer (Noviat) <1047525@xxxxxxxxxxxxxxxxxx>

> A new version of this module has been uploaded which takes over the
> company currency in case the currency has not been defined on the
> journal.
>
> Luc
>
> -----Original Message-----
> From: bounces@xxxxxxxxxxxxx [mailto:bounces@xxxxxxxxxxxxx] On Behalf Of
> Houssine
> Sent: dinsdag 11 september 2012 14:17
> To: luc.demeyer@xxxxxxxxx
> Subject: Re: [Bug 1047525] Re: account_pain module wrong currency check
>
> Hi Luc,
>
> In fact, this is not a matter of supporting the multicurrency. I'm
> reffering to currency check rule that force you to set the currency on
> the journal which should not in case of the used currency is the same
> that the company currency.
>
> So your module force to set € as currency for the used journal even if €
> is already defined at the company level. This lead to other
> problems(other openerp check => while doing reconcile for example)
>
> I don't know if I'm clear...
>
> there is no need to retrofit this to 6.0 as we are working on the 6.1.
>
> Regards,
> Houssine
>
> On Tue, Sep 11, 2012 at 1:07 PM, Luc De Meyer (Noviat) <
> 1047525@xxxxxxxxxxxxxxxxxx> wrote:
>
> > Enhancement of this module to support payments in multiple currencies
> > is on our development roadmap for this month, but only for 6.1 version
> > of this module.
> > Let me know if retrofitting in 6.0 is a requirement.
> >
> > -----Original Message-----
> > From: bounces@xxxxxxxxxxxxx [mailto:bounces@xxxxxxxxxxxxx] On Behalf
> > Of Houssine
> > Sent: dinsdag 11 september 2012 11:15
> > To: luc.demeyer@xxxxxxxxx
> > Subject: Re: [Bug 1047525] Re: account_pain module wrong currency
> > check
> >
> > Hi Amit,
> >
> > Thanks for you feedback!
> >
> > Kind regards,
> > Houssine BAKKALI
> >
> > On Mon, Sep 10, 2012 at 11:30 AM, Amit Parik (OpenERP)
> > <amp@xxxxxxxxxxx>wrote:
> >
> > > Hello,
> > >
> > > I am assigning this to related author of the branch who can take the
> > > decision on it.
> > >
> > > Thank you!
> > >
> > > ** Changed in: openobject-addons
> > >      Assignee: (unassigned) => Luc De Meyer (Noviat) (luc-demeyer)
> > >
> > > --
> > > You received this bug notification because you are subscribed to the
> > > bug report.
> > > https://bugs.launchpad.net/bugs/1047525
> > >
> > > Title:
> > >   account_pain module wrong currency check
> > >
> > > Status in OpenERP Addons (modules):
> > >   New
> > >
> > > Bug description:
> > >   Hi,
> > >
> > >   I've found a wrong currency check in in the pain_wizard.py file of
> the
> > >   account_pain module.
> > >
> > >   In the test described by the following code :
> > >
> > >         if payment.mode.journal.currency.name != 'EUR':
> > >                   raise osv.except_osv(_('Payment Order Error!'),
> > >                       _('Only payments from a EURO bank account are
> > > supported in the current release '   \
> > >                         'of the ISO 20022 payment module!'))
> > >
> > >   The test doens't take into account the company currency.
> > >
> > >   In fact, it just check if the currency 's journal is different of
> > >   'EUR' which should be always the case if the company currency is
> > >   'EUR'. As you can't define the same currency for an account that for
> > >   the company.
> > >
> > >   the test should take this into account reflect something like this
> > >
> > >   if company.currency_id.name != 'EUR':
> > >               if payment.mode.journal.currency.name != 'EUR':
> > >                   raise osv.except_osv(_('Payment Order Error!'),
> > >                       _('Only payments from a EURO bank account are
> > > supported in the current release '   \
> > >                         'of the ISO 20022 payment module!'))
> > >
> > >   Hope that this will help to improve this already excellent module!
> > >
> > >   Kinds Regards,
> > >   Houssine
> > >
> > > To manage notifications about this bug go to:
> > > https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscript
> > > io
> > > ns
> > >
> >
> > --
> > You received this bug notification because you are a bug assignee.
> > https://bugs.launchpad.net/bugs/1047525
> >
> > Title:
> >   account_pain module wrong currency check
> >
> > Status in OpenERP Addons (modules):
> >   New
> >
> > Bug description:
> >   Hi,
> >
> >   I've found a wrong currency check in in the pain_wizard.py file of the
> >   account_pain module.
> >
> >   In the test described by the following code :
> >
> >         if payment.mode.journal.currency.name != 'EUR':
> >                   raise osv.except_osv(_('Payment Order Error!'),
> >                       _('Only payments from a EURO bank account are
> > supported in the current release '   \
> >                         'of the ISO 20022 payment module!'))
> >
> >   The test doens't take into account the company currency.
> >
> >   In fact, it just check if the currency 's journal is different of
> >   'EUR' which should be always the case if the company currency is
> >   'EUR'. As you can't define the same currency for an account that for
> >   the company.
> >
> >   the test should take this into account reflect something like this
> >
> >   if company.currency_id.name != 'EUR':
> >               if payment.mode.journal.currency.name != 'EUR':
> >                   raise osv.except_osv(_('Payment Order Error!'),
> >                       _('Only payments from a EURO bank account are
> > supported in the current release '   \
> >                         'of the ISO 20022 payment module!'))
> >
> >   Hope that this will help to improve this already excellent module!
> >
> >   Kinds Regards,
> >   Houssine
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptio
> > ns
> >
> > --
> > You received this bug notification because you are subscribed to the
> > bug report.
> > https://bugs.launchpad.net/bugs/1047525
> >
> > Title:
> >   account_pain module wrong currency check
> >
> > Status in OpenERP Addons (modules):
> >   New
> >
> > Bug description:
> >   Hi,
> >
> >   I've found a wrong currency check in in the pain_wizard.py file of the
> >   account_pain module.
> >
> >   In the test described by the following code :
> >
> >         if payment.mode.journal.currency.name != 'EUR':
> >                   raise osv.except_osv(_('Payment Order Error!'),
> >                       _('Only payments from a EURO bank account are
> > supported in the current release '   \
> >                         'of the ISO 20022 payment module!'))
> >
> >   The test doens't take into account the company currency.
> >
> >   In fact, it just check if the currency 's journal is different of
> >   'EUR' which should be always the case if the company currency is
> >   'EUR'. As you can't define the same currency for an account that for
> >   the company.
> >
> >   the test should take this into account reflect something like this
> >
> >   if company.currency_id.name != 'EUR':
> >               if payment.mode.journal.currency.name != 'EUR':
> >                   raise osv.except_osv(_('Payment Order Error!'),
> >                       _('Only payments from a EURO bank account are
> > supported in the current release '   \
> >                         'of the ISO 20022 payment module!'))
> >
> >   Hope that this will help to improve this already excellent module!
> >
> >   Kinds Regards,
> >   Houssine
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptio
> > ns
> >
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1047525
>
> Title:
>   account_pain module wrong currency check
>
> Status in OpenERP Addons (modules):
>   New
>
> Bug description:
>   Hi,
>
>   I've found a wrong currency check in in the pain_wizard.py file of the
>   account_pain module.
>
>   In the test described by the following code :
>
>         if payment.mode.journal.currency.name != 'EUR':
>                   raise osv.except_osv(_('Payment Order Error!'),
>                       _('Only payments from a EURO bank account are
> supported in the current release '   \
>                         'of the ISO 20022 payment module!'))
>
>   The test doens't take into account the company currency.
>
>   In fact, it just check if the currency 's journal is different of
>   'EUR' which should be always the case if the company currency is
>   'EUR'. As you can't define the same currency for an account that for
>   the company.
>
>   the test should take this into account reflect something like this
>
>   if company.currency_id.name != 'EUR':
>               if payment.mode.journal.currency.name != 'EUR':
>                   raise osv.except_osv(_('Payment Order Error!'),
>                       _('Only payments from a EURO bank account are
> supported in the current release '   \
>                         'of the ISO 20022 payment module!'))
>
>   Hope that this will help to improve this already excellent module!
>
>   Kinds Regards,
>   Houssine
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptions
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1047525
>
> Title:
>   account_pain module wrong currency check
>
> Status in OpenERP Addons (modules):
>   New
>
> Bug description:
>   Hi,
>
>   I've found a wrong currency check in in the pain_wizard.py file of the
>   account_pain module.
>
>   In the test described by the following code :
>
>         if payment.mode.journal.currency.name != 'EUR':
>                   raise osv.except_osv(_('Payment Order Error!'),
>                       _('Only payments from a EURO bank account are
> supported in the current release '   \
>                         'of the ISO 20022 payment module!'))
>
>   The test doens't take into account the company currency.
>
>   In fact, it just check if the currency 's journal is different of
>   'EUR' which should be always the case if the company currency is
>   'EUR'. As you can't define the same currency for an account that for
>   the company.
>
>   the test should take this into account reflect something like this
>
>   if company.currency_id.name != 'EUR':
>               if payment.mode.journal.currency.name != 'EUR':
>                   raise osv.except_osv(_('Payment Order Error!'),
>                       _('Only payments from a EURO bank account are
> supported in the current release '   \
>                         'of the ISO 20022 payment module!'))
>
>   Hope that this will help to improve this already excellent module!
>
>   Kinds Regards,
>   Houssine
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptions
>

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1047525

Title:
  account_pain module wrong currency check

Status in OpenERP Addons (modules):
  New

Bug description:
  Hi,

  I've found a wrong currency check in in the pain_wizard.py file of the
  account_pain module.

  In the test described by the following code :

        if payment.mode.journal.currency.name != 'EUR':
                  raise osv.except_osv(_('Payment Order Error!'),
                      _('Only payments from a EURO bank account are supported in the current release '   \
                        'of the ISO 20022 payment module!'))     

  The test doens't take into account the company currency.

  In fact, it just check if the currency 's journal is different of
  'EUR' which should be always the case if the company currency is
  'EUR'. As you can't define the same currency for an account that for
  the company.

  the test should take this into account reflect something like this

  if company.currency_id.name != 'EUR':
              if payment.mode.journal.currency.name != 'EUR':
                  raise osv.except_osv(_('Payment Order Error!'),
                      _('Only payments from a EURO bank account are supported in the current release '   \
                        'of the ISO 20022 payment module!'))   

  Hope that this will help to improve this already excellent module!

  Kinds Regards,
  Houssine

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1047525/+subscriptions