openerp-india team mailing list archive

["Alexandre Fayolle @ camptocamp" <alexandre.fayolle@xxxxxxxxxxxxxx>]

Public bug reported:

In l10n_fr/report/base_report.py the _load_accounts method has two
suspicious lines performing a down rounding:

                            if(value<0.001): value=0.0

1. The hard coded 0.001 should probably use the precision configured for
accounting

2. I'm concerned that `value` could be a large negative number, and
therefore get nullified. IMO,  the test should be performed on
abs(value) and not on value itself

This affects 6.0, 6.1 and trunk.

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1084424

Title:
  l10n_fr: suspicious comparison in base_report.py

Status in OpenERP Addons (modules):
  New

Bug description:
  In l10n_fr/report/base_report.py the _load_accounts method has two
  suspicious lines performing a down rounding:

                              if(value<0.001): value=0.0

  1. The hard coded 0.001 should probably use the precision configured
  for accounting

  2. I'm concerned that `value` could be a large negative number, and
  therefore get nullified. IMO,  the test should be performed on
  abs(value) and not on value itself

  This affects 6.0, 6.1 and trunk.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1084424/+subscriptions