openerp-india team mailing list archive

["Amit Parik \(OpenERP\)" <amp@xxxxxxxxxxx>]

Hello,

I agree with the 2nd solution about the domain.

Thank you!

** Summary changed:

- wrongly used product cost as timesheet invoice price 
+ Employee : Jounral_id field must have a domain for journal type

** Changed in: openobject-addons
   Importance: Undecided => Low

** Changed in: openobject-addons
       Status: New => Confirmed

** Changed in: openobject-addons
     Assignee: (unassigned) => OpenERP R&D Addons Team 3 (openerp-dev-addons3)

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1222394

Title:
  Employee : Jounral_id field must have a domain for journal type

Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  tested on runbot 7-0-19466

  I am reading the change http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9317
  I found there should be something wrong at

   line 233      elif journal_type == 'general' and product_id:

  I doubt can we assume all timesheet line with analytic journal type
  'general'

  then I did a test:

  on runbot 7-0-19466

  change the employee administrator's journal from "timesheet journal"
  to "Purchase" (no exception raised)

  make a timesheet line for Administrator, mark invoice 100%

  invoice on this timesheet, the unit price is 30, from the cost of
  "service", In this case, it should be 75 from list price of "service"

  possible solution:

  my advise is in this elseif leg, check the journal_type='purchase'
  first and look it as Expense line, put the timesheet logic in else
  leg, remove the   journal_type == 'general'  condition because it is
  not always true for timesheet

  another solution should be , add a domain on journal_id field of
  Employee form, make it filter to only [('type','=','general')]
  analytic journals.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1222394/+subscriptions