← Back to team overview

openerp-india team mailing list archive

[Bug 1273251] [NEW] [trunk][saas-2][7.0]Sanitizing html content when saving new template corrupts placeholders in some html attributes

 

Public bug reported:

To reproduce:
- go to one of the runbot/saas-2 instances
- From Messaging/Organizer/Contacts, select a partner from the partner list
- More/Partner Mass Mailing
- fill-in a subject
- click on the "Show Source" button of the body composer
- insert an html tag like this: <a href="${object.id}">Hello</a>
- save as new template
- click on the "Show Source" button again
- the body has been sanitized like this: <a href="%24%7Bobject.id%7D">Hello</a>
- at this point, accepting to send the mail from the composer does not produce expected effect, i.e., replacement of placeholders by real values inside the html href attributes.

In this use case, it seems the method "html_sanitize" is called too
early.

Notes:
- By clicking on the (new) template link in the composer, we can see that the "transformation" affects also the final content of the new template not only the body of the mail in the composer
- can also be reproduced on [7.0]
- tested on revision 5004 of [saas-2/server]

Thanks to fix this issue on both [saas-2] and [7.0] branches.

** Affects: openobject-addons
     Importance: Undecided
         Status: New

** Summary changed:

- Sanitizing html content when saving new template corrupts placeholders in some html attributes
+ [trunk][saas-2][7.0]Sanitizing html content when saving new template corrupts placeholders in some html attributes

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1273251

Title:
  [trunk][saas-2][7.0]Sanitizing html content when saving new template
  corrupts placeholders in some html attributes

Status in OpenERP Addons (modules):
  New

Bug description:
  To reproduce:
  - go to one of the runbot/saas-2 instances
  - From Messaging/Organizer/Contacts, select a partner from the partner list
  - More/Partner Mass Mailing
  - fill-in a subject
  - click on the "Show Source" button of the body composer
  - insert an html tag like this: <a href="${object.id}">Hello</a>
  - save as new template
  - click on the "Show Source" button again
  - the body has been sanitized like this: <a href="%24%7Bobject.id%7D">Hello</a>
  - at this point, accepting to send the mail from the composer does not produce expected effect, i.e., replacement of placeholders by real values inside the html href attributes.

  In this use case, it seems the method "html_sanitize" is called too
  early.

  Notes:
  - By clicking on the (new) template link in the composer, we can see that the "transformation" affects also the final content of the new template not only the body of the mail in the composer
  - can also be reproduced on [7.0]
  - tested on revision 5004 of [saas-2/server]

  Thanks to fix this issue on both [saas-2] and [7.0] branches.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1273251/+subscriptions


Follow ups

References