openerp-india team mailing list archive

[Prakash Pandey <prakashpp.pandey@xxxxxxxxx>]

Public bug reported:

If a comment field has a length based validation, it works if a string
value exists for the field. however, if the comment field is left blank,
the validation does not work.

This is because of the poor logic in create method [1].

The condition in [1] already kicks in condition [2] is never evaluated.

[1] https://github.com/akretion/openerp-addons/blob/318685c447ab88144e00d903cc5e72448708cd96/survey/wizard/survey_answer.py#L676
[2] https://github.com/akretion/openerp-addons/blob/318685c447ab88144e00d903cc5e72448708cd96/survey/wizard/survey_answer.py#L681

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1283017

Title:
  Survey comment field text validation is wrong

Status in OpenERP Addons (modules):
  New

Bug description:
  If a comment field has a length based validation, it works if a string
  value exists for the field. however, if the comment field is left
  blank, the validation does not work.

  This is because of the poor logic in create method [1].

  The condition in [1] already kicks in condition [2] is never
  evaluated.

  [1] https://github.com/akretion/openerp-addons/blob/318685c447ab88144e00d903cc5e72448708cd96/survey/wizard/survey_answer.py#L676
  [2] https://github.com/akretion/openerp-addons/blob/318685c447ab88144e00d903cc5e72448708cd96/survey/wizard/survey_answer.py#L681

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1283017/+subscriptions