← Back to team overview

openerp-india team mailing list archive

[Bug 1297563] [NEW] [7.0] issue cleaning code, unused variables

 

Public bug reported:

Hello,
We make a new pylint script with only
pylint --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" -d all -e E0601 -e E1124 -e E0602 -e E1306 -e E0101 ./static/openerp-dev-7-0-944/server/openerp

The result was:
************* Module openerp.report.render.rml2txt.rml2txt
static/openerp-dev-7-0-943/server/openerp/report/render/rml2txt/rml2txt.py:401: [E0602(undefined-variable), _rml_template.set_next_template] Undefined variable 'name'
************* Module openerp.report.render.rml2html.rml2html
static/openerp-dev-7-0-943/server/openerp/report/render/rml2html/rml2html.py:308: [E0602(undefined-variable), _rml_template.set_next_template] Undefined variable 'name'
************* Module openerp.tools.amount_to_text_en
static/openerp-dev-7-0-943/server/openerp/tools/amount_to_text_en.py:127: [E0602(undefined-variable), ] Undefined variable 'int_to_text'
static/openerp-dev-7-0-943/server/openerp/tools/amount_to_text_en.py:129: [E0602(undefined-variable), ] Undefined variable 'int_to_text'
static/openerp-dev-7-0-943/server/openerp/tools/amount_to_text_en.py:131: [E0602(undefined-variable), ] Undefined variable 'int_to_text'
************* Module openerp.addons.resource.faces.task
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:970: [E0602(undefined-variable), VariableLoad] Undefined variable 'me'
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1285: [E0601(used-before-assignment), SloppyAllocator.test_allocation_length] Using variable 'start' before assignment
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1483: [E0602(undefined-variable), YearlyMax] Undefined variable 'me'
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1505: [E0602(undefined-variable), WeeklyMax] Undefined variable 'me'
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1527: [E0602(undefined-variable), MonthlyMax] Undefined variable 'me'
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1549: [E0602(undefined-variable), DailyMax] Undefined variable 'me'
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:2323: [E0601(used-before-assignment), Task._convert_performed] Using variable 'last_end' before assignment
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:2325: [E0601(used-before-assignment), Task._convert_performed] Using variable 'last_index' before assignment
************* Module openerp.addons.resource.faces.resource
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/resource.py:749: [E0602(undefined-variable), _ResourceGroup._permutation_count] Undefined variable 'abstract'
static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/resource.py:777: [E0602(undefined-variable), _ResourceGroup.__str__] Undefined variable 'lower'
************* Module openerp.addons.document_ftp.ftpserver.abstracted_fs
static/openerp-dev-7-0-943/server/openerp/addons/document_ftp/ftpserver/abstracted_fs.py:194: [E0602(undefined-variable), abstracted_fs.mkstemp] Undefined variable 'node'
************* Module openerp.addons.document_ftp.ftpserver.authorizer
static/openerp-dev-7-0-943/server/openerp/addons/document_ftp/ftpserver/authorizer.py:51: [E0602(undefined-variable), authorizer.has_perm] Undefined variable 'pooler'
static/openerp-dev-7-0-943/server/openerp/addons/document_ftp/ftpserver/authorizer.py:52: [E0602(undefined-variable), authorizer.has_perm] Undefined variable 'security'
************* Module openerp.addons.sale_crm.sale_crm
static/openerp-dev-7-0-943/server/openerp/addons/sale_crm/sale_crm.py:30: [E0101(return-in-init), res_users.__init__] Explicit return in __init__
************* Module openerp.addons.mail.res_users
static/openerp-dev-7-0-943/server/openerp/addons/mail/res_users.py:46: [E0101(return-in-init), res_users.__init__] Explicit return in __init__
************* Module openerp.addons.account_followup.report.account_followup_print
static/openerp-dev-7-0-943/server/openerp/addons/account_followup/report/account_followup_print.py:86: [E0602(undefined-variable), report_rappel._get_text] Undefined variable 'osv'
static/openerp-dev-7-0-943/server/openerp/addons/account_followup/report/account_followup_print.py:86: [E0602(undefined-variable), report_rappel._get_text] Undefined variable '_'
static/openerp-dev-7-0-943/server/openerp/addons/account_followup/report/account_followup_print.py:86: [E0602(undefined-variable), report_rappel._get_text] Undefined variable '_'
************* Module openerp.addons.document_webdav.test_davclient
static/openerp-dev-7-0-943/server/openerp/addons/document_webdav/test_davclient.py:58: [E0602(undefined-variable), PersistentTransport.__init__] Undefined variable 'log'
static/openerp-dev-7-0-943/server/openerp/addons/document_webdav/test_davclient.py:255: [E0602(undefined-variable), addAuthTransport.request] Undefined variable 'log'
static/openerp-dev-7-0-943/server/openerp/addons/document_webdav/test_davclient.py:404: [E0602(undefined-variable), DAVClient._http_request] Undefined variable 'log'
************* Module openerp.addons.mrp_repair.wizard.make_invoice
static/openerp-dev-7-0-943/server/openerp/addons/mrp_repair/wizard/make_invoice.py:60: [E0602(undefined-variable), make_invoice.make_invoices] Undefined variable 'Fals'
************* Module openerp.addons.account.report.account_print_overdue
static/openerp-dev-7-0-943/server/openerp/addons/account/report/account_print_overdue.py:45: [E0602(undefined-variable), Overdue._tel_get] Undefined variable 'res_partner_address'
************* Module openerp.addons.account.wizard.account_financial_report
static/openerp-dev-7-0-943/server/openerp/addons/account/wizard/account_financial_report.py:71: [E0602(undefined-variable), accounting_report._build_comparison_context] Undefined variable '_'
static/openerp-dev-7-0-943/server/openerp/addons/account/wizard/account_financial_report.py:71: [E0602(undefined-variable), accounting_report._build_comparison_context] Undefined variable '_'
************* Module openerp.addons.sale_stock.sale_stock
static/openerp-dev-7-0-943/server/openerp/addons/sale_stock/sale_stock.py:650: [E0602(undefined-variable), sale_advance_payment_inv._create_invoices] Undefined variable 'inv_amount'
static/openerp-dev-7-0-943/server/openerp/addons/sale_stock/sale_stock.py:653: [E0602(undefined-variable), sale_advance_payment_inv._create_invoices] Undefined variable 'res'
static/openerp-dev-7-0-943/server/openerp/addons/sale_stock/sale_stock.py:654: [E0602(undefined-variable), sale_advance_payment_inv._create_invoices] Undefined variable 'res'

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1297563

Title:
  [7.0] issue cleaning code, unused variables

Status in OpenERP Addons (modules):
  New

Bug description:
  Hello,
  We make a new pylint script with only
  pylint --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" -d all -e E0601 -e E1124 -e E0602 -e E1306 -e E0101 ./static/openerp-dev-7-0-944/server/openerp

  The result was:
  ************* Module openerp.report.render.rml2txt.rml2txt
  static/openerp-dev-7-0-943/server/openerp/report/render/rml2txt/rml2txt.py:401: [E0602(undefined-variable), _rml_template.set_next_template] Undefined variable 'name'
  ************* Module openerp.report.render.rml2html.rml2html
  static/openerp-dev-7-0-943/server/openerp/report/render/rml2html/rml2html.py:308: [E0602(undefined-variable), _rml_template.set_next_template] Undefined variable 'name'
  ************* Module openerp.tools.amount_to_text_en
  static/openerp-dev-7-0-943/server/openerp/tools/amount_to_text_en.py:127: [E0602(undefined-variable), ] Undefined variable 'int_to_text'
  static/openerp-dev-7-0-943/server/openerp/tools/amount_to_text_en.py:129: [E0602(undefined-variable), ] Undefined variable 'int_to_text'
  static/openerp-dev-7-0-943/server/openerp/tools/amount_to_text_en.py:131: [E0602(undefined-variable), ] Undefined variable 'int_to_text'
  ************* Module openerp.addons.resource.faces.task
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:970: [E0602(undefined-variable), VariableLoad] Undefined variable 'me'
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1285: [E0601(used-before-assignment), SloppyAllocator.test_allocation_length] Using variable 'start' before assignment
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1483: [E0602(undefined-variable), YearlyMax] Undefined variable 'me'
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1505: [E0602(undefined-variable), WeeklyMax] Undefined variable 'me'
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1527: [E0602(undefined-variable), MonthlyMax] Undefined variable 'me'
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:1549: [E0602(undefined-variable), DailyMax] Undefined variable 'me'
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:2323: [E0601(used-before-assignment), Task._convert_performed] Using variable 'last_end' before assignment
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/task.py:2325: [E0601(used-before-assignment), Task._convert_performed] Using variable 'last_index' before assignment
  ************* Module openerp.addons.resource.faces.resource
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/resource.py:749: [E0602(undefined-variable), _ResourceGroup._permutation_count] Undefined variable 'abstract'
  static/openerp-dev-7-0-943/server/openerp/addons/resource/faces/resource.py:777: [E0602(undefined-variable), _ResourceGroup.__str__] Undefined variable 'lower'
  ************* Module openerp.addons.document_ftp.ftpserver.abstracted_fs
  static/openerp-dev-7-0-943/server/openerp/addons/document_ftp/ftpserver/abstracted_fs.py:194: [E0602(undefined-variable), abstracted_fs.mkstemp] Undefined variable 'node'
  ************* Module openerp.addons.document_ftp.ftpserver.authorizer
  static/openerp-dev-7-0-943/server/openerp/addons/document_ftp/ftpserver/authorizer.py:51: [E0602(undefined-variable), authorizer.has_perm] Undefined variable 'pooler'
  static/openerp-dev-7-0-943/server/openerp/addons/document_ftp/ftpserver/authorizer.py:52: [E0602(undefined-variable), authorizer.has_perm] Undefined variable 'security'
  ************* Module openerp.addons.sale_crm.sale_crm
  static/openerp-dev-7-0-943/server/openerp/addons/sale_crm/sale_crm.py:30: [E0101(return-in-init), res_users.__init__] Explicit return in __init__
  ************* Module openerp.addons.mail.res_users
  static/openerp-dev-7-0-943/server/openerp/addons/mail/res_users.py:46: [E0101(return-in-init), res_users.__init__] Explicit return in __init__
  ************* Module openerp.addons.account_followup.report.account_followup_print
  static/openerp-dev-7-0-943/server/openerp/addons/account_followup/report/account_followup_print.py:86: [E0602(undefined-variable), report_rappel._get_text] Undefined variable 'osv'
  static/openerp-dev-7-0-943/server/openerp/addons/account_followup/report/account_followup_print.py:86: [E0602(undefined-variable), report_rappel._get_text] Undefined variable '_'
  static/openerp-dev-7-0-943/server/openerp/addons/account_followup/report/account_followup_print.py:86: [E0602(undefined-variable), report_rappel._get_text] Undefined variable '_'
  ************* Module openerp.addons.document_webdav.test_davclient
  static/openerp-dev-7-0-943/server/openerp/addons/document_webdav/test_davclient.py:58: [E0602(undefined-variable), PersistentTransport.__init__] Undefined variable 'log'
  static/openerp-dev-7-0-943/server/openerp/addons/document_webdav/test_davclient.py:255: [E0602(undefined-variable), addAuthTransport.request] Undefined variable 'log'
  static/openerp-dev-7-0-943/server/openerp/addons/document_webdav/test_davclient.py:404: [E0602(undefined-variable), DAVClient._http_request] Undefined variable 'log'
  ************* Module openerp.addons.mrp_repair.wizard.make_invoice
  static/openerp-dev-7-0-943/server/openerp/addons/mrp_repair/wizard/make_invoice.py:60: [E0602(undefined-variable), make_invoice.make_invoices] Undefined variable 'Fals'
  ************* Module openerp.addons.account.report.account_print_overdue
  static/openerp-dev-7-0-943/server/openerp/addons/account/report/account_print_overdue.py:45: [E0602(undefined-variable), Overdue._tel_get] Undefined variable 'res_partner_address'
  ************* Module openerp.addons.account.wizard.account_financial_report
  static/openerp-dev-7-0-943/server/openerp/addons/account/wizard/account_financial_report.py:71: [E0602(undefined-variable), accounting_report._build_comparison_context] Undefined variable '_'
  static/openerp-dev-7-0-943/server/openerp/addons/account/wizard/account_financial_report.py:71: [E0602(undefined-variable), accounting_report._build_comparison_context] Undefined variable '_'
  ************* Module openerp.addons.sale_stock.sale_stock
  static/openerp-dev-7-0-943/server/openerp/addons/sale_stock/sale_stock.py:650: [E0602(undefined-variable), sale_advance_payment_inv._create_invoices] Undefined variable 'inv_amount'
  static/openerp-dev-7-0-943/server/openerp/addons/sale_stock/sale_stock.py:653: [E0602(undefined-variable), sale_advance_payment_inv._create_invoices] Undefined variable 'res'
  static/openerp-dev-7-0-943/server/openerp/addons/sale_stock/sale_stock.py:654: [E0602(undefined-variable), sale_advance_payment_inv._create_invoices] Undefined variable 'res'

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1297563/+subscriptions


Follow ups

References