openjdk team mailing list archive
-
openjdk team
-
Mailing list archive
-
Message #14049
Bug#944738: Bug#944738: jlink: Hash of module differs to expected hash recorded in java.base
On Wed, Sep 23, 2020 at 01:45:23PM +0100, Julian Gilbey wrote:
> On Mon, Sep 21, 2020 at 10:49:24PM -0700, tony mancill wrote:
> > > * Run the sha256sum command (protected with a '-' in case it fails!)
> > > at several points in the build-arch and install targets to see when
> > > the hashes change, if at all.
> >
> > Good idea. I am doing that now, and also building without parallelism,
> > since I'd like to see the build logs for a single jmod being built
> > without those being interspersed with others. Specifically, I'd like to
> > see the order in which the jmods are built and the hashes recorded.
> > Somewhere along the line, we must be invoking jmod hash / --hash-modules
> > on a jmod before strip-nondeterminism was invoked.
> > [...]
> > Thank you for the ideas. I will keep working on it.
>
> Aargh, I've found what I did that was different from what I *said* I
> did: I left in the dh_strip_nondeterminism -Xjmods option. Leaving
> that option out breaks it: it turns out that dh_strip_nondeterminism
> sets a different timestamp from strip-nondeterminism.
>
> dh_strip_nondeterminism gets its timestamp from the debian/changelog
> file, while strip-nondeterminism strips the timestamps.
>
> So here's a replacement patch which fixes everything except
> java.naming.jmod. I have to run now, but will try to figure out
> tomorrow why that one still breaks.
I rebuilt with this patch (and also my NONPARALLEL patch) and am able to
call jlink against all of the modules shipped with the resulting JDK
binary package. So this is looking good.
I'm rebuilding now (without nonparallel) what should be the NMU candidate.
Thanks!
tony
Follow ups
References