openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
Looks good but a couple of comments:

Print statements still present should these be log.debug

 __AutoLanguage__ = None  should be  __AutoLanguage__ = False if used for boolean tests

if LanguageManager.__AutoLanguage__ == True:  can become if LanguageManager.__AutoLanguage__. Can be amended in other places as well.

line 406 extra blank

line 429 missing trUtf8 wrapper for message popup.

lines 411 440 need splitting for the 80 limit.



 
-- 
https://code.launchpad.net/~crichter/openlp/i18n/+merge/23588
Your team OpenLP Core is subscribed to branch lp:openlp.