openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~crichter/openlp/i18n into lp:openlp

To: rimach <crichter@xxxxxx>
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 19 Apr 2010 07:11:33 -0000
In-reply-to: <20100416221414.30224.3073.launchpad@loganberry.canonical.com>
Reply-to: mp+23588@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
If a class member is named __<MemberName>__ it should not be accessed outside the class. Please either rename these members, or access them via a property.

Also, LanguageManager is not a Qt-based class, therefore it should follow the Python naming convention. Please see the coding standards on the wiki.

Please join us in IRC. We have been chatting about this amongst other things, and we have a roadmap for when things should be completed.
-- 
https://code.launchpad.net/~crichter/openlp/i18n/+merge/23588
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~crichter/openlp/i18n into lp:openlp
From: rimach, 2010-04-16