openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
Generally good but:
Why remove a return of False to a string which then needs testing
Not happy about you trying to add the ability to use "V" for verses again. Tried to test and got stack traces.


Traceback (most recent call last):
  File "/home/timali/dev/projects/openlp/work/openlp/plugins/songs/forms/editsongform.py", line 609, in accept
    if self.saveSong():
  File "/home/timali/dev/projects/openlp/work/openlp/plugins/songs/forms/editsongform.py", line 621, in saveSong
    status, message = self._validate_song()
  File "/home/timali/dev/projects/openlp/work/openlp/plugins/songs/forms/editsongform.py", line 574, in _validate_song
    order_names[count].replace(u':', u' '),
IndexError: list index out of range
Traceback (most recent call last):
  File "/home/timali/dev/projects/openlp/work/openlp/plugins/songs/forms/editsongform.py", line 609, in accept
    if self.saveSong():
  File "/home/timali/dev/projects/openlp/work/openlp/plugins/songs/forms/editsongform.py", line 621, in saveSong
    status, message = self._validate_song()
  File "/home/timali/dev/projects/openlp/work/openlp/plugins/songs/forms/editsongform.py", line 574, in _validate_song
    order_names[count].replace(u':', u' '),
IndexError: list index out of range

-- 
https://code.launchpad.net/~m2j/openlp/work/+merge/28007
Your team OpenLP Core is subscribed to branch lp:openlp.