← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~meths/openlp/testing into lp:openlp

 

> In v1.2 we have a Video tab and an Audio tab in the media manager. The audio
> files in the Audio tab can be linked to a song via the song editor. The song
> editor also has the option to add new songs to the Audio tab, for convenience
> sake.
The song editor interaction with convenience is how I see v2 working as well.

> In v2, we have the Media tab, and at some point in the past a decision was
> made that this would merge both the v1.2 video and audio tabs. Therefore I
> expected that when we added backing tracks, the songs would link to items in
> this Media tab.
Adding items to the media tab when they are added to a song should be optional so churches that make heavy use of scenario 1 below won't have their media tab swamped with backing tracks that just get in the way of them finding what they want.  We could have two lists (probably horizontal tabs on the media "tab") for "General" and "Backing music" if everything needs to be displayed in media manager?

> However this merge seems to have a new audio_files table, which I guess is
> independent of whatever is used to store the Media tab files? Could we
> consider moving the media filenames into the database (if they are not already
> there) and linking songs to a media_files table instead? (It is entirely
> possible that someone may want to use a video for a backing track anyway, but
> just want the music not the visuals)
I see the point about having videos also providing audio for songs but I think we need to decide which scenarios we want to support.

1 - Backing track - This is the obvious one where a church may not have musicians or they just prefer singing to a track.  They will use this track every time and so it should be in the database and loaded into the service with the song.

2 - Backing video - This is the one you have introduced above where they may want the audio from a video or both audio and video for the song.  If they are just using the audio then firstly they should grab the audio and save it separately but ignoring that then the audio_files name is still apt.  Will they really want the same video every time they sing the song?  If yes maybe we should say media_files; if no then see scenario 3.

3 - Ad-hoc media - This is probably one of the most common scenarios where you want a video playing behind something or you want sound this time to go with a song or you want to have music with an image slideshow.  I see this working as a drag and drop from the media tab to an item on the service.  This is a service association and doesn't need storing in a DB.

An implementation point to consider is how we handle deletion of media.  If I delete a media item that is being used as a backing track should the item be deleted, only be removed from media but left as a backing track, or nothing removed with a notification to the user or a mix that lets the user decide?
-- 
https://code.launchpad.net/~meths/openlp/testing/+merge/30369
Your team OpenLP Core is requested to review the proposed merge of lp:~meths/openlp/testing into lp:openlp.



Follow ups

References