← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~meths/openlp/testing into lp:openlp

 

> Looks good but have a question.
> How does it stop from eating my database.  Do I have to back it up before I
> start up the new version?
It won't eat the database as sqlalchemy thinks the song table is there and doesn't check if the schema is correct - the database actually crashes OpenLP.  So yes the change would come with notification that you need to move/rename/backup the database, let OpenLP create a new (correctly formatted) one and then use the new imported to get the data back.

> From a code point of view 1 and 2 above are similar and can be handled within
> the song.  If you tag a song with a theme it has a background.  If you add
> video then this file should be on the file system but added via the song and
> NOT media as media and song plugins are not connected. If the video does not
> exist at run time the default is the theme background.  In the same way an
> image could be included.
> 2 fields need to support this Path and Type {Image, Video}.
Good point about plugin separation.  So we are saying s/audio_files/media_files and add a type field to the media_files table?

> The ad-Hoc would work as I have in the renderer branch and allows 1 off quick
> changes.
Cool
-- 
https://code.launchpad.net/~meths/openlp/testing/+merge/30369
Your team OpenLP Core is subscribed to branch lp:openlp.



References