openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
Like it but not fully.
There are two types of Critical message.  Those which have Yes/No and those which do not.
Can you use Raoul's framework for the latter but yours is good for the response ones.
Raoul's was based on the mainwindow so the parentage would be correct.  Do you need to consider that?
-- 
https://code.launchpad.net/~meths/openlp/testing/+merge/46367
Your team OpenLP Core is subscribed to branch lp:openlp.