openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Tim Bentley has proposed merging lp:~trb143/openlp/wizard into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~trb143/openlp/wizard/+merge/52592

Fix issues with first time wizard.
-- 
https://code.launchpad.net/~trb143/openlp/wizard/+merge/52592
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/wizard into lp:openlp.

=== modified file 'openlp/core/ui/firsttimeform.py'
--- openlp/core/ui/firsttimeform.py	2011-03-07 17:38:04 +0000
+++ openlp/core/ui/firsttimeform.py	2011-03-08 18:56:16 +0000
@@ -66,6 +66,9 @@
             'Starting Updates')
         self.downloading = unicode(translate('OpenLP.FirstTimeWizard',
             'Downloading %s'))
+        QtCore.QObject.connect(self,
+            QtCore.SIGNAL(u'currentIdChanged(int)'),
+            self.onCurrentIdChanged)
 
     def exec_(self, edit=False):
         """
@@ -116,12 +119,12 @@
                 child.setFlags(QtCore.Qt.ItemIsUserCheckable |
                     QtCore.Qt.ItemIsSelectable | QtCore.Qt.ItemIsEnabled)
 
-    def initializePage(self, id):
-        """
-        Set up the pages for Initial run through dialog
-        """
-        wizardPage = self.page(id)
-        if wizardPage == self.DefaultsPage:
+    def onCurrentIdChanged(self, pageId):
+        """
+        Detects Page changes and updates as approprate.
+        """
+        if self.page(pageId) == self.DefaultsPage:
+            self.themeSelectionComboBox.clear()
             listIterator = QtGui.QTreeWidgetItemIterator(
                 self.selectionTreeWidget)
             while listIterator.value():
@@ -134,6 +137,7 @@
                 listIterator += 1
 
     def accept(self):
+        Receiver.send_message(u'cursor_busy')
         self._updateMessage(self.startUpdates)
         # Set up the Plugin status's
         self._pluginStatus(self.songsCheckBox, u'songs/status')
@@ -197,6 +201,7 @@
                 QtCore.QVariant(self.themeSelectionComboBox.currentText()))
         QtCore.QSettings().setValue(u'general/first time',
             QtCore.QVariant(False))
+        Receiver.send_message(u'cursor_normal')
         return QtGui.QWizard.accept(self)
 
     def _pluginStatus(self, field, tag):

=== modified file 'openlp/core/ui/firsttimewizard.py'
--- openlp/core/ui/firsttimewizard.py	2011-03-05 09:23:47 +0000
+++ openlp/core/ui/firsttimewizard.py	2011-03-08 18:56:16 +0000
@@ -224,4 +224,4 @@
         self.themeSelectionLabel.setText(translate('OpenLP.FirstTimeWizard',
             'Select the default Theme'))
         self.messageLabel.setText(translate('OpenLP.FirstTimeWizard',
-            'Press Finish to apply all you changes and start OpenLP'))
+            'Press finish to apply all your changes and start OpenLP'))