openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Just a comment from me:
You can try to save indents. For example you could remove line 26 and remove one indent (on the following lines), due to the return in line 25. There are also situations were you can use continue, e. g. line 49+50 would become:
if not item[u'service_item'].uses_file():
    continue

That makes the code more readable.
-- 
https://code.launchpad.net/~mahfiaz/openlp/media_fixes/+merge/52533
Your team OpenLP Core is subscribed to branch lp:openlp.