openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
30	+ {u'search': u'%s' % (u'Bible-List'),

Why do you do string interpolation on a static string? That's doing more processing that what is actually required. Just do "{u'search': 'Bible-List'}"

84	+ if book.contents[0].contents[0] == u'Numeri':
85	+     book.contents[0].contents[0] = u'Numbers'
86	+ elif book.contents[0].contents[0] == u'Habbakuk':
87	+     book.contents[0].contents[0] = u'Habakkuk'

Why are you doing this?
-- 
https://code.launchpad.net/~orangeshirt/openlp/webbibles/+merge/52615
Your team OpenLP Core is subscribed to branch lp:openlp.