openlp-core team mailing list archive

[Armin Köhler <orangeshirt@xxxxxx>]

> 30      + {u'search': u'%s' % (u'Bible-List'),
> 
> Why do you do string interpolation on a static string? That's doing more
> processing that what is actually required. Just do "{u'search': 'Bible-List'}"

Because I don't know it better. I'll change it. Remember i'm learning.

> 
> 84      + if book.contents[0].contents[0] == u'Numeri':
> 85      +     book.contents[0].contents[0] = u'Numbers'
> 86      + elif book.contents[0].contents[0] == u'Habbakuk':
> 87      +     book.contents[0].contents[0] = u'Habakkuk'
> 
> Why are you doing this?

On Bibleserver.com this two booknames differ from the openlp name scheme - I rename them, otherwise I got an error in line 144 while fetching book_details.
-- 
https://code.launchpad.net/~orangeshirt/openlp/webbibles/+merge/52615
Your team OpenLP Core is subscribed to branch lp:openlp.