openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Hello,
Alright, the speed problem is solved now, thanks.

Thinks which need fixing:
- you have a conflict with trunk (resources.py)
- it seems, that you don't need the import (os.path) in line 638
- It will be better to use lower() when comparing books (see this http://img823.imageshack.us/i/bildschirmfoto010520111.png/)
- Also it might be better only to show those books on dialog which are not already added (so, if the wizard already imported Genesis then Genesis does not need to be in the drop down list). This will make upgrading much easier.
- A dialog at start up (after loading) might be a good idea (otherwise we will have dozens of bug reports "My Bibles are gone - HELP!")

I get this traceback when importing the KJV (included in the First Time Wizad). This wizard stops by "Esther".
Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/forms/bibleupgradeform.py", line 144, in onCurrentIdChanged
    self.performWizard()
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/forms/bibleupgradeform.py", line 639, in performWizard
    for verse in verses:
TypeError: 'NoneType' object is not iterable


The rest I tested worked fine.
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/59116
Your team OpenLP Core is subscribed to branch lp:openlp.