openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
App start looks good but the plugin super class class should be amended so you do not need the hasattr line.
Not sure about being triggered from OpenLP.pyw as the theme code is triggered from mainwindow.py line
self.themeManagerContents.loadThemes(True).

Maybe that should be moved and then appStartUp() called from MainWindow.py.

382 should be log.debug.
439 Is this used.  If it is then the re.compile should be moved to the top.  Stop Andreas doing it later!


-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/62318
Your team OpenLP Core is subscribed to branch lp:openlp.