openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Hello Gerald,

You need to provide error messages in lines 44 and 46 (if you do not provide one, the default one is taken, which says "Title and/or verses not found").

Why did you add RuntimeException to the sof but not to ooo? The ooo importer also has similar code in process_doc!?

By the way, when you fixed or changed something and are finished with it, then please resubmit your proposal ("Resubmit proposal" in the upper right corner). Otherwise we do not know when you are done and want us to look at it again.

Keep it up!
-- 
https://code.launchpad.net/~gerald-britton/openlp/newbugs/+merge/62211
Your team OpenLP Core is subscribed to branch lp:openlp.