openlp-core team mailing list archive

[Simon Scudder <samscudder@xxxxxxxxx>]

Simon Scudder has proposed merging lp:~samscudder/openlp/bug-795945 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #795945 in OpenLP: "Text colour appearing in shadow"
  https://bugs.launchpad.net/openlp/+bug/795945

For more details, see:
https://code.launchpad.net/~samscudder/openlp/bug-795945/+merge/64305

Function showtext in the html javascript was altered, so that the shadow layer (if present) will ignore all the font color settings. This is done using a regular expression replace, that searches for -webkit-text-fill-color and erases up to the first ; or "

If there is only a colour formatting command in the span tag, an empty class attribute is left behind, which shouldn't be a problem.
-- 
https://code.launchpad.net/~samscudder/openlp/bug-795945/+merge/64305
Your team OpenLP Core is requested to review the proposed merge of lp:~samscudder/openlp/bug-795945 into lp:openlp.

=== modified file 'openlp/core/lib/htmlbuilder.py'
--- openlp/core/lib/htmlbuilder.py	2011-05-26 17:11:22 +0000
+++ openlp/core/lib/htmlbuilder.py	2011-06-11 15:34:37 +0000
@@ -261,7 +261,7 @@
             clearTimeout(timer);
         text_fade('lyricsmain', newtext);
         text_fade('lyricsoutline', newtext);
-        text_fade('lyricsshadow', newtext);
+        text_fade('lyricsshadow', newtext.replace(/-webkit-text-fill-color:[^;\"]+/gi, ""));
         if(text_opacity()==1) return;
         timer = setTimeout(function(){
             show_text(newtext);