← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~smpettit/openlp/save_service into lp:openlp

 

> Shouldn't you use "os.path.exists" rather than "os.path.isfile"?
> 
> You've commwnted out a whole section of code that looks quite important. Did
> you mean to do this? If it should not be there, please remove the comments.

I thought os.path.exists was used to check if a directory exists and os.path.isfile checks for files.

Openlp uses both.

The commented code was already there.  It appears it was used to keep the saved service file under 50mb.  I can remove it, if you wish.
-- 
https://code.launchpad.net/~smpettit/openlp/save_service/+merge/70356
Your team OpenLP Core is subscribed to branch lp:openlp.


References