← Back to team overview

openlp-core team mailing list archive

[Bug 863376] [NEW] "<" in song lyrics causes a traceback

 

Public bug reported:

Hello,

When a song's lyrics  contains "<" (and you try to preview the song)
then the following traceback is shown.

**OpenLP Bug Report**
Version: {u'full': u'1.9.7-bzr1765', u'version': u'1.9.7', u'build': u'bzr1765'}

--- Exception Traceback ---
Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 506, in onClickPressed
    self.onPreviewClick()
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 529, in onPreviewClick
    serviceItem = self.buildServiceItem()
  File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 623, in buildServiceItem
    if self.generateSlideData(serviceItem, item, xmlVersion, remote):
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/mediaitem.py", line 509, in generateSlideData
    service_item.xml_version = self.openLyrics.song_to_xml(song)
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 341, in song_to_xml
    virtual_verse, tags_element)
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 450, in _add_text_with_tags_to_lines
    element = etree.XML(text)
  File "lxml.etree.pyx", line 2723, in lxml.etree.XML (src/lxml/lxml.etree.c:52448)
  File "parser.pxi", line 1573, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:79932)
  File "parser.pxi", line 1445, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:78709)
  File "parser.pxi", line 920, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:75083)
  File "parser.pxi", line 564, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
  File "parser.pxi", line 645, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:72614)
  File "parser.pxi", line 585, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:71955)
XMLSyntaxError: StartTag: invalid element name, line 1, column 23

--- System information ---
Plattform: Linux-3.0-ARCH-i686-Intel-R-_Pentium-R-_4_CPU_1.80GHz-with-glibc2.0

--- Library Versions ---
Python: 2.7.2
Qt4: 4.7.4
Phonon: 4.5.55
PyQt4: 4.8.5
SQLAlchemy: 0.7.2
BeautifulSoup: 3.2.0
lxml: 2.3.0
Chardet: 2.0.1
PyEnchant: 1.6.3
PySQLite: 1.0.1

** Affects: openlp
     Importance: High
         Status: New

** Description changed:

  Hello,
  
- When a song's lyrics  contains "<" then the following traceback is
- shown.
+ When a song's lyrics  contains "<" (and you try to preview the song)
+ then the following traceback is shown.
  
  **OpenLP Bug Report**
  Version: {u'full': u'1.9.7-bzr1765', u'version': u'1.9.7', u'build': u'bzr1765'}
  
  --- Exception Traceback ---
  Traceback (most recent call last):
-   File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 506, in onClickPressed
-     self.onPreviewClick()
-   File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 529, in onPreviewClick
-     serviceItem = self.buildServiceItem()
-   File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 623, in buildServiceItem
-     if self.generateSlideData(serviceItem, item, xmlVersion, remote):
-   File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/mediaitem.py", line 509, in generateSlideData
-     service_item.xml_version = self.openLyrics.song_to_xml(song)
-   File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 341, in song_to_xml
-     virtual_verse, tags_element)
-   File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 450, in _add_text_with_tags_to_lines
-     element = etree.XML(text)
-   File "lxml.etree.pyx", line 2723, in lxml.etree.XML (src/lxml/lxml.etree.c:52448)
-   File "parser.pxi", line 1573, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:79932)
-   File "parser.pxi", line 1445, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:78709)
-   File "parser.pxi", line 920, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:75083)
-   File "parser.pxi", line 564, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
-   File "parser.pxi", line 645, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:72614)
-   File "parser.pxi", line 585, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:71955)
+   File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 506, in onClickPressed
+     self.onPreviewClick()
+   File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 529, in onPreviewClick
+     serviceItem = self.buildServiceItem()
+   File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 623, in buildServiceItem
+     if self.generateSlideData(serviceItem, item, xmlVersion, remote):
+   File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/mediaitem.py", line 509, in generateSlideData
+     service_item.xml_version = self.openLyrics.song_to_xml(song)
+   File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 341, in song_to_xml
+     virtual_verse, tags_element)
+   File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 450, in _add_text_with_tags_to_lines
+     element = etree.XML(text)
+   File "lxml.etree.pyx", line 2723, in lxml.etree.XML (src/lxml/lxml.etree.c:52448)
+   File "parser.pxi", line 1573, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:79932)
+   File "parser.pxi", line 1445, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:78709)
+   File "parser.pxi", line 920, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:75083)
+   File "parser.pxi", line 564, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
+   File "parser.pxi", line 645, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:72614)
+   File "parser.pxi", line 585, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:71955)
  XMLSyntaxError: StartTag: invalid element name, line 1, column 23
  
  --- System information ---
  Plattform: Linux-3.0-ARCH-i686-Intel-R-_Pentium-R-_4_CPU_1.80GHz-with-glibc2.0
  
  --- Library Versions ---
  Python: 2.7.2
  Qt4: 4.7.4
  Phonon: 4.5.55
  PyQt4: 4.8.5
  SQLAlchemy: 0.7.2
  BeautifulSoup: 3.2.0
  lxml: 2.3.0
  Chardet: 2.0.1
  PyEnchant: 1.6.3
  PySQLite: 1.0.1

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/863376

Title:
  "<" in song lyrics causes a traceback

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  Hello,

  When a song's lyrics  contains "<" (and you try to preview the song)
  then the following traceback is shown.

  **OpenLP Bug Report**
  Version: {u'full': u'1.9.7-bzr1765', u'version': u'1.9.7', u'build': u'bzr1765'}

  --- Exception Traceback ---
  Traceback (most recent call last):
    File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 506, in onClickPressed
      self.onPreviewClick()
    File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 529, in onPreviewClick
      serviceItem = self.buildServiceItem()
    File "/home/andreas/Projekte/openlp/trunk/openlp/core/lib/mediamanageritem.py", line 623, in buildServiceItem
      if self.generateSlideData(serviceItem, item, xmlVersion, remote):
    File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/mediaitem.py", line 509, in generateSlideData
      service_item.xml_version = self.openLyrics.song_to_xml(song)
    File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 341, in song_to_xml
      virtual_verse, tags_element)
    File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/songs/lib/xml.py", line 450, in _add_text_with_tags_to_lines
      element = etree.XML(text)
    File "lxml.etree.pyx", line 2723, in lxml.etree.XML (src/lxml/lxml.etree.c:52448)
    File "parser.pxi", line 1573, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:79932)
    File "parser.pxi", line 1445, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:78709)
    File "parser.pxi", line 920, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:75083)
    File "parser.pxi", line 564, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:71739)
    File "parser.pxi", line 645, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:72614)
    File "parser.pxi", line 585, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:71955)
  XMLSyntaxError: StartTag: invalid element name, line 1, column 23

  --- System information ---
  Plattform: Linux-3.0-ARCH-i686-Intel-R-_Pentium-R-_4_CPU_1.80GHz-with-glibc2.0

  --- Library Versions ---
  Python: 2.7.2
  Qt4: 4.7.4
  Phonon: 4.5.55
  PyQt4: 4.8.5
  SQLAlchemy: 0.7.2
  BeautifulSoup: 3.2.0
  lxml: 2.3.0
  Chardet: 2.0.1
  PyEnchant: 1.6.3
  PySQLite: 1.0.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/863376/+subscriptions


Follow ups

References