openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #12970
Re: [Merge] lp:~crichter/openlp/media into lp:openlp
Review: Needs Fixing
I wasn't planning on reviewing, but as I scanned through I noticed a discrepancy between the comment on line 6396
"Wait no longer than 5 seconds."
and the code on line 6405:
if (datetime.now() - start).seconds > 50:
And whilst I'm here:
in play() and update_ui() there should be spaces around all the * and / operators.
--
https://code.launchpad.net/~crichter/openlp/media/+merge/84275
Your team OpenLP Core is subscribed to branch lp:openlp.
References