openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing

try:
    import vlc
    if vlc.get_default_instance():
        vlc_available = True
except:
    vlc_available = False

Should be

try:
    import vlc
    if vlc.get_default_instance():
        vlc_available = True
except ImportError:
    vlc_available = False

Please add "--no-video-title-show" as command line options or change it to:

        if display.hasAudio:
            command_line_options = u'--no-video-title-show'
        else:
            command_line_options = u'--no-audio --no-video-title-show'

Also add a check if the option "Hide mouse cursor when over display window" is enabled and depending of its state pass "--mouse-hide-timeout=0" as well.
-- 
https://code.launchpad.net/~crichter/openlp/media/+merge/84275
Your team OpenLP Core is subscribed to branch lp:openlp.