← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/bug-905040 into lp:openlp

To: mp+87201@xxxxxxxxxxxxxxxxxx
From: Jon Tibble <meths@xxxxxxxxxxxxxx>
Date: Sun, 01 Jan 2012 12:30:29 -0000
In-reply-to: <20120101042722.30866.53994.launchpad@ackee.canonical.com>
Reply-to: mp+87201@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Just looking at this and wondering about recursion/duplicating code execution - should line 12 be "return self.saveFileAs()" like servicemanager.py:479?
-- 
https://code.launchpad.net/~smpettit/openlp/bug-905040/+merge/87201
Your team OpenLP Core is requested to review the proposed merge of lp:~smpettit/openlp/bug-905040 into lp:openlp.

Follow ups

Re: [Merge] lp:~smpettit/openlp/bug-905040 into lp:openlp
From: Stevan Pettit, 2012-01-01

References

[Merge] lp:~smpettit/openlp/bug-905040 into lp:openlp
From: Stevan Pettit, 2012-01-01