openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/bug-905040 into lp:openlp

To: Jon Tibble <meths@xxxxxxxxxxxxxx>
From: Stevan Pettit <openlp@xxxxxxxxxxxxxxx>
Date: Sun, 01 Jan 2012 13:51:23 -0000
In-reply-to: <20120101123008.30933.28311.codereview@chaenomeles.canonical.com>
Reply-to: mp+87201@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Just looking at this and wondering about recursion/duplicating code execution
> - should line 12 be "return self.saveFileAs()" like servicemanager.py:479?

I thought about that after I submitted the proposal.  It never ceases to amaze me of the statements available in Python.  Thanks for the learning "experience". 
-- 
https://code.launchpad.net/~smpettit/openlp/bug-905040/+merge/87201
Your team OpenLP Core is requested to review the proposed merge of lp:~smpettit/openlp/bug-905040 into lp:openlp.

References

Re: [Merge] lp:~smpettit/openlp/bug-905040 into lp:openlp
From: Jon Tibble, 2012-01-01