← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

To: mp+95156@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 04 Mar 2012 18:18:18 -0000
In-reply-to: <20120229120917.3365.36747.launchpad@ackee.canonical.com>
Reply-to: mp+95156@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

IF your BibleStrings class is based on the UiStrings class, please go back and look at exactly how we did that class, as currently none of those strings in your BibleStrings class will ever be translated.
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/95156
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~orangeshirt/openlp/bibles into lp:openlp
From: Armin Köhler, 2012-02-29