openlp-core team mailing list archive

[Meinert Jordan <meinertjordan@xxxxxxxxxx>]

I do not understand, why you are writing a new class (with one object and no methods).
Instead of that you could write (on the top level like REFERENCE_MATCHES):

BOOKNAMES = {
    u'Gen': translate('BiblesPlugin','Genesis'),
    ...}

Then you can access everything with BOOKNAMES[key].

With a class you have to write more code, and access via a longer command (BibleStrings().Booknames[key]). I do not see any advantage, as you have neither need for additional properties nor you need special methods for the access.

* Note: REFERENCE_MATCHES is a bad example, as it changes its value while runtime. But for unchanging values this is optimal.
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/95156
Your team OpenLP Core is subscribed to branch lp:openlp.