openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing

Lines 45-128 should have a space after the comma.
Line 396: Spaces either side of the +'s

294-297, change to:
294	+        self.languageSelectionLabel.setText(translate('BiblesPlugin.BiblesTab',
295	+            'Choose the language in which the book names of the\nBible should '
296	+            'be displayed in the Bible search:'))

306-309:
306	+            translate('BiblesPlugin.BiblesTab', 'Multiple options:\n '
307	+                'Bible language - the language in which the Bible book names '
308	+                'were imported\n Application language - the language you have '
309	+                'chosen for Openlp\n English - always use English book names'))


I just tried this, I got the branch and ran it (In default language, since I don't know how to get a different language when running from a branch). I went into the settings and set to use the Bible language.
I brought up the first time wizard and downloaded some non English Bibles.

Then when I went into the Advanced Bible Media Manager, I changed the Bible version, but at the top all the book names are still in English. Is there something I don't understand?
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/96437
Your team OpenLP Core is subscribed to branch lp:openlp.