openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing

Now had time to look a bit more closely, sorry for not noticing earlier.

Missing u's on line 61

Blank line too many at line 63

Line 161 I think you can do: (note the u before ')
    if overriddenPlayer and overriddenPlayer != u'auto':

Line 240, I think you can just do:
   if overridePlayer:

Why at 52 and 77 are you creating the used one time only can_override variable? Couldn't you just replace

    can_override = True if QtCore.QSettings().value(u'media/override player',
        QtCore.QVariant(QtCore.Qt.Unchecked)) == QtCore.Qt.Checked else False
    if can_override:

with:

    if QtCore.QSettings().value(u'media/override player',
        QtCore.QVariant(QtCore.Qt.Unchecked)) == QtCore.Qt.Checked:
?
-- 
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98522
Your team OpenLP Core is subscribed to branch lp:openlp.