openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

line 344 extra space
353,354,355 these can be local variables and not class variables 
368 and 369 should be before 360 and the "if not self.webbible" optomised
validateMetaData should use local variables and get them passed as args

604 and 627 should request list of bibles each time and not save the list!

662 should be None not -1.  None is missing -1 is a value this will confuse later.  It may need to be handled in a different place in the code.   

-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/101616
Your team OpenLP Core is subscribed to branch lp:openlp.