openlp-core team mailing list archive

[Armin Köhler <orangeshirt@xxxxxx>]

> 368 and 369 should be before 360 
Two Questions:
1. Why only before 360 (book validation) and not before 358 (meta validation)?
2. Is this really necessary, the Validation needs only some milliseconds - saving needs much time, if many values was changed. If I switch the cursor to busy before the validation i have to but a "cursor normal" at every possibility where validation could show a warning (417,424,436 and maybe 387,393,402), otherwise the cursor shows busy as long as the users push the ok button of the warning message.
I prefer to leave the lines where they are at the moment. Please tell if I really should change this.


> 662 should be None not -1.  None is missing -1 is a value this will confuse
> later.  It may need to be handled in a different place in the code.
-1 is the value which was saved at the moment if the user choose "Global Settings" (compare line 213 respectivly 356f.) that's why I use it in line 662. 
It is no problem to change it in line 662 to None. My question is: 
Should I use None instead of -1 at the other points too?
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/101616
Your team OpenLP Core is subscribed to branch lp:openlp.