← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~googol/openlp/bug-977835 into lp:openlp

 

Andreas Preikschat has proposed merging lp:~googol/openlp/bug-977835 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #977835 in OpenLP: "Advanced search of Bibles is not working."
  https://bugs.launchpad.net/openlp/+bug/977835

For more details, see:
https://code.launchpad.net/~googol/openlp/bug-977835/+merge/101718

Hello,

- fixed bug #977835 (Advanced search of Bibles is not working.)
-- 
https://code.launchpad.net/~googol/openlp/bug-977835/+merge/101718
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-977835 into lp:openlp.
=== modified file 'openlp/plugins/bibles/lib/__init__.py'
--- openlp/plugins/bibles/lib/__init__.py	2012-04-04 07:26:51 +0000
+++ openlp/plugins/bibles/lib/__init__.py	2012-04-12 11:26:18 +0000
@@ -386,7 +386,7 @@
                         if bible.get_book_by_book_ref_id(value[u'id']):
                             book_ref_id = value[u'id']
                             break
-        elif bible.get_book_by_book_ref_id(book_ref_id):
+        elif not bible.get_book_by_book_ref_id(book_ref_id):
             book_ref_id = False
         ranges = match.group(u'ranges')
         range_list = get_reference_match(u'range_separator').split(ranges)


Follow ups