← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~orangeshirt/openlp/bibles_fixes into lp:openlp

 

Review: Needs Fixing

You don't declare "initialise_chapter_verse" in a scope where it may be used. If the if-statement on line 26 is false, then "initialise_chapter_verse" is undefined. If the if-statements on lines 29 and 35 are false, then "initialise_chapter_verse" is undefined as well.

Lines 56 and 63 need to be indented one more.
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103017
Your team OpenLP Core is subscribed to branch lp:openlp.


Follow ups

References