← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~sfindlay/openlp/refactor-song-import into lp:openlp

 

Review: Needs Fixing

430,1073 - extra blank line

1209-1222 - Magic numbers ??  Need comment to explain value as there is some thinking to them.

Tested with a text file as that's all I have.
Select file OK.
Selected Import.  Told LibreOffice was not present.  LibreOffice then started.  No Option to go back.
Cancelled and re-ran import.  Said import complete but no clue as to what was imported.
-- 
https://code.launchpad.net/~sfindlay/openlp/refactor-song-import/+merge/108757
Your team OpenLP Core is subscribed to branch lp:openlp.


Follow ups

References