openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

You've got:

    from os.path import split
    ...
    ... = split(...)

split() is also a string method. When it comes to the os.path module, we usually just import the entire thing, because there is no benefit to only importing a particular function, and since a number of the methods are ambiguous it is less confusing to use "os.path.split".

Move strip_rtf into openlp.plugins.songs.lib, as previously proposed.

SongImporter, and SundayPlusImporter by extension, is a 1t-derived class, and all methods should be camelCase.
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-933706/+merge/111162
Your team OpenLP Core is subscribed to branch lp:openlp.