← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #16241

Re: [Merge] lp:~mahfiaz/openlp/bug-933706 into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Fixing

hotkeyToVerseType is constant so should be CAPITALS and constant!
Like wise destinations etc.  Even if they are in their own class.

Failed the 11th commandment about print statements!
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-933706/+merge/111162
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next