← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #16306

Re: [Merge] lp:~j-corwin/openlp/bug-1016843 into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Information

Why did you moved the code to the _set_text_rectangle method? Why not in the constructor?

Line 43: Don't we always use %s instead of +?
-- 
https://code.launchpad.net/~j-corwin/openlp/bug-1016843/+merge/112229
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next