← Back to team overview

openlp-core team mailing list archive

[Bug 1020915] [NEW] OpenSong Bible import has uncaught exception on non-xml file

 

Public bug reported:

If a non-xml file is supplied to the OpenSong Bible importer, an
uncaught XMLSyntaxError is raised. Unfortunately, users sometimes
attempt to import the zip file downloaded from the OpenSong website, not
realising they need to first extract the XML .xmm file [1]. Even though
this is explained in the manual [2], it should fail more gracefully than
a traceback.

[1] http://www.support.openlp.org/issues/894
[2] http://manual.openlp.org/bibles.html#importing-opensong-bibles

---Traceback (most recent call last): File 
D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.core.ui.wizard, 
line 187, in onCurrentIdChanged File 
D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.bibles.forms.bibleimportform, 
line 714, in performWizard File 
D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.bibles.lib.opensong, 
line 80, in do_import File lxml.objectify.pyx, line 1866, in 
lxml.objectify.parse (src/lxml/lxml.objectify.c:18773) File 
lxml.etree.pyx, line 2942, in lxml.etree.parse 
(src/lxml/lxml.etree.c:54187) File parser.pxi, line 1550, in 
lxml.etree._parseDocument (src/lxml/lxml.etree.c:79703) File parser.pxi, 
line 1580, in lxml.etree._parseFilelikeDocument 
(src/lxml/lxml.etree.c:80012) File parser.pxi, line 1463, in 
lxml.etree._parseDocFromFilelike (src/lxml/lxml.etree.c:78908) File 
parser.pxi, line 1019, in lxml.etree._BaseParser._parseDocFromFilelike 
(src/lxml/lxml.etree.c:75905) File parser.pxi, line 564, in 
lxml.etree._ParserContext._handleParseResultDoc 
(src/lxml/lxml.etree.c:71739) File parser.pxi, line 645, in 
lxml.etree._handleParseResult (src/lxml/lxml.etree.c:72614) File 
parser.pxi, line 585, in lxml.etree._raiseParseError 
(src/lxml/lxml.etree.c:71955)XMLSyntaxError: Start tag expected, ' not 
found, line 1, column 1

** Affects: openlp
     Importance: Low
         Status: New

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1020915

Title:
  OpenSong Bible import has uncaught exception on non-xml file

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  If a non-xml file is supplied to the OpenSong Bible importer, an
  uncaught XMLSyntaxError is raised. Unfortunately, users sometimes
  attempt to import the zip file downloaded from the OpenSong website,
  not realising they need to first extract the XML .xmm file [1]. Even
  though this is explained in the manual [2], it should fail more
  gracefully than a traceback.

  [1] http://www.support.openlp.org/issues/894
  [2] http://manual.openlp.org/bibles.html#importing-opensong-bibles

  ---Traceback (most recent call last): File 
  D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.core.ui.wizard, 
  line 187, in onCurrentIdChanged File 
  D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.bibles.forms.bibleimportform, 
  line 714, in performWizard File 
  D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.bibles.lib.opensong, 
  line 80, in do_import File lxml.objectify.pyx, line 1866, in 
  lxml.objectify.parse (src/lxml/lxml.objectify.c:18773) File 
  lxml.etree.pyx, line 2942, in lxml.etree.parse 
  (src/lxml/lxml.etree.c:54187) File parser.pxi, line 1550, in 
  lxml.etree._parseDocument (src/lxml/lxml.etree.c:79703) File parser.pxi, 
  line 1580, in lxml.etree._parseFilelikeDocument 
  (src/lxml/lxml.etree.c:80012) File parser.pxi, line 1463, in 
  lxml.etree._parseDocFromFilelike (src/lxml/lxml.etree.c:78908) File 
  parser.pxi, line 1019, in lxml.etree._BaseParser._parseDocFromFilelike 
  (src/lxml/lxml.etree.c:75905) File parser.pxi, line 564, in 
  lxml.etree._ParserContext._handleParseResultDoc 
  (src/lxml/lxml.etree.c:71739) File parser.pxi, line 645, in 
  lxml.etree._handleParseResult (src/lxml/lxml.etree.c:72614) File 
  parser.pxi, line 585, in lxml.etree._raiseParseError 
  (src/lxml/lxml.etree.c:71955)XMLSyntaxError: Start tag expected, ' not 
  found, line 1, column 1

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1020915/+subscriptions


Follow ups

References