← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~phill-ridout/openlp/1065420 into lp:openlp

To: mp+132422@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Thu, 01 Nov 2012 07:48:19 -0000
In-reply-to: <20121031211120.9486.63977.launchpad@ackee.canonical.com>
Reply-to: mp+132422@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

No it does not 
Lines 102 to 107 plays with the internals of a serviceItem so should be a ServiceItem Helper function returning True or False.
False means the the serviceItem should be removed from the service line 108-109
-- 
https://code.launchpad.net/~phill-ridout/openlp/1065420/+merge/132422
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~phill-ridout/openlp/1065420 into lp:openlp
From: phill, 2012-10-31