openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~phill-ridout/openlp/1065420 into lp:openlp

To: mp+132422@xxxxxxxxxxxxxxxxxx
From: phill <phill.ridout@xxxxxxxxxxxxxx>
Date: Thu, 01 Nov 2012 12:51:21 -0000
In-reply-to: <20121031211120.9486.63977.launchpad@ackee.canonical.com>
Reply-to: mp+132422@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Ah, sorry about that. It looks like the changes I made last night have not got pushed up, hence I've just resubmitted what I had before.

>From you current review, I've got a lot closer, but have a small change to make. I'll try and get it done this evening.

As for the helper function, do you think calling it "is_valid" is ok? Hence returning True would cause the valid item to be saved, returning False would cause the invalid item to be removed.
-- 
https://code.launchpad.net/~phill-ridout/openlp/1065420/+merge/132422
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~phill-ridout/openlp/1065420 into lp:openlp
From: phill, 2012-10-31