openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp

To: mohij <patrick@xxxxxxxxx>
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 03 Nov 2012 20:48:18 -0000
In-reply-to: <20121101194025.24873.34267.launchpad@ackee.canonical.com>
Reply-to: mp+132614@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Lines 18, 44+45 (of the diff below): We use single quotes, not double quotes. Please make sure you stick to our coding standards.

I'm also unsure of this change (though I haven't had the chance to test it out yet). The biggest problem at the moment is Windows because the alternate colour is too /different/, not too /similar/.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/132614
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp
From: mohij, 2012-11-01