openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

50 def validate(self):
51     """
52     Validates this service item
53     """
54     if not self._raw_frames:
55         self.is_valid = False
56     return self.is_valid

Unless you're using self.is_valid elsewhere in the code, that attribute has no reason to exist and is just using up extra memory. As for "but we might use it later on", I call YAGNI (Ya Ain't Gonna Need It). Add it when you need it.

50 def validate(self):
51     """
52     Validates this service item
53     """
54     return bool(self._raw_frames)

-- 
https://code.launchpad.net/~phill-ridout/openlp/1065420/+merge/132735
Your team OpenLP Core is subscribed to branch lp:openlp.